Add file upload templates #15
Conversation
theof-db
left a comment
theof-db
left a comment
There was a problem hiding this comment.
Hey Pascal! I've talked with @NickKramer-DB today and we've decided that these are more samples than templates. We want templates to work out of the box, so when a user creates an app using a template it just works. However, these are very useful app samples, and the Databricks apps team needs to figure out a way to share samples that aren't templates. We also plan on adding UC volumes as resources at some point, so that will allow files to be uploaded in a non-hardcoded way
| volume = 'my-volume' | ||
| volume_path = f"/Volumes/{catalog}/{schema}/{volume}" | ||
| volume_folder = 'my-folder' | ||
| volume_folder_path = f"{volume_path}/{volume_folder}" |
There was a problem hiding this comment.
For templates, we don't want paths to be hardcoded because it means that the template won't work for everyone who installs the template.
There was a problem hiding this comment.
Hi @theof-db , thanks for reviewing!
We can also have the user specify the volume in the sample app UI. That way, the path would not be hard coded, and the template would deploy out of the box.
However, the user would still have to give the service principal permissions to the volume before the actual upload works. We could add a quick guide/link to the docs in the sample app UI to enable that. Let me know if those changes would help.
Otherwise, if we need to wait for UC volumes as app resources we can close the pull request.
There was a problem hiding this comment.
Hi @pbv0,
Even with these changes, it still doesn't meet our goals for a seamless setup that we want for our template apps. Because of this, we will need to wait for UC volumes as app resources before closing the pull request. @NickKramer-DB might have ideas for how we can get these examples out to customers before then though so that people can still build apps using UC volumes
theof-db
force-pushed
the
main
branch
2 times, most recently
from
3fc8498 to
ea975f7
Compare
2 participants
Proposing file upload templates for Dash, Flask, Gradio, Shiny for Python. Streamlit is covered in a separate pull request here.