Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deal with conan zstd dependency #27

Closed
wants to merge 1 commit into from

Conversation

Hailios
Copy link
Contributor

@Hailios Hailios commented Apr 4, 2024

Pull request

this changes the cmake target that is used to build databento-cpp incase zstd is installed with a different cmake target name (for example via Conan). This is because Conan installed zstd only defines zstd::libzstd_static while databento looked for only ztsd::zstd. https://conan.io/center/recipes/zstd.
with this change, it will first check for the conan installed target (to allow users to more freely choose zstd version), and use the system wide installed zstd target as fallback.

Type of change

allow databento-cpp to be built with conan installed zstd.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How has this change been tested?

Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration.

c++ project using conan and cmake. databento-cpp is included as a git submodule and a cmake subdirectory.

  • built project including databento-cpp as submodule with system installed zstd
  • built project including databento-cpp as submodule with conan installed zstd

Checklist

  • My code builds locally with no new warnings (scripts/build.sh).
  • New and existing unit tests pass locally with my changes (scripts/test.sh)
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Declaration

I confirm this contribution is made under an Apache 2.0 license and that I have the authority
necessary to make this contribution on behalf of its copyright owner.

@threecgreen
Copy link
Contributor

Merged in 8472c8c

@threecgreen threecgreen closed this Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants