Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
this changes the cmake target that is used to build databento-cpp incase zstd is installed with a different cmake target name (for example via Conan). This is because Conan installed zstd only defines
zstd::libzstd_static
while databento looked for onlyztsd::zstd
. https://conan.io/center/recipes/zstd.with this change, it will first check for the conan installed target (to allow users to more freely choose zstd version), and use the system wide installed zstd target as fallback.
Type of change
allow databento-cpp to be built with conan installed zstd.
How has this change been tested?
Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration.
c++ project using conan and cmake. databento-cpp is included as a git submodule and a cmake subdirectory.
Checklist
scripts/build.sh
).scripts/test.sh
)Declaration
I confirm this contribution is made under an Apache 2.0 license and that I have the authority
necessary to make this contribution on behalf of its copyright owner.