FIX: Fix cppcheck on GitHub

databento · Jul 11, 2023 · 15e7041 · 15e7041
1 parent 52c9803
commit 15e7041
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 5 deletions.
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
@@ -4,7 +4,6 @@ name: build
 
 on:
   push:
-    branches: [main, dev]
 
 jobs:
   ubuntu:
@@ -20,9 +19,20 @@ jobs:
       - name: Checkout repository
         uses: actions/checkout@v3
       - name: Install dependencies
+        # pcre is a dependency of cppcheck
         run: |
           sudo apt-get update
-          sudo apt-get install cppcheck libzstd-dev ninja-build
+          sudo apt-get install libpcre3 libpcre3-dev libzstd-dev ninja-build
+      - name: Install cppcheck
+        run: |
+          git clone https://github.com/danmar/cppcheck.git
+          cd cppcheck
+          cmake -S. -B build \
+            -DCMAKE_BUILD_TYPE=Release \
+            -DUSE_MATCHCOMPILER=1 \
+            -DHAVE_RULES=1
+          cmake --build build --config Release
+          sudo cmake --install build --prefix /usr
       - name: Install gtest
         uses: MarkusJx/[email protected]
       - name: CMake configure

diff --git a/src/historical.cpp b/src/historical.cpp
@@ -246,8 +246,9 @@ std::vector<databento::BatchJob> Historical::BatchListJobs(
     throw JsonResponseError::TypeMismatch(kEndpoint, "array", json);
   }
   std::vector<BatchJob> jobs;
-  std::transform(json.begin(), json.end(), std::back_inserter(jobs),
-                 [](const auto& item) { return ::Parse(kEndpoint, item); });
+  std::transform(
+      json.begin(), json.end(), std::back_inserter(jobs),
+      [](const nlohmann::json& item) { return ::Parse(kEndpoint, item); });
   return jobs;
 }
 
@@ -859,7 +860,7 @@ databento::SymbologyResolution Historical::SymbologyResolve(
     std::vector<StrMappingInterval> mapping_intervals;
     std::transform(mapping_json.begin(), mapping_json.end(),
                    std::back_inserter(mapping_intervals),
-                   [](const auto& interval_json) {
+                   [](const nlohmann::json& interval_json) {
                      return StrMappingInterval{
                          detail::CheckedAt(kEndpoint, interval_json, "d0"),
                          detail::CheckedAt(kEndpoint, interval_json, "d1"),