Remove OMP_NUM_THREADS if set to empty #8917
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generally though, sometimes our use of OMP_NUM_THREADS makes other systems sad. It's unfortunately somewhat difficult to turn off. A common approach is that people set `OMP_NUM_THREADS=""` but this doesn't properly unset things. I'm curious if an approach like this would be helpful. There might be a cleaner way to do this, and this might be a bad idea. Please feel free to reject. It was just easy to put this up as a PR.
Not anytime soon but seems like a positive change to me. |
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 25 files ± 0 25 suites ±0 10h 21m 20s ⏱️ + 7m 36s For more details on these failures, see this check. Results for commit e8d9b81. ± Comparison against base commit 2953090. |
|
No objections. It appears to not be working, though. The test is failing (linter is also off) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally though, sometimes our use of OMP_NUM_THREADS makes other systems sad. It's unfortunately somewhat difficult to turn off. A common approach is that people set
OMP_NUM_THREADS=""but this doesn't properly unset things.I'm curious if an approach like this would be helpful.
There might be a cleaner way to do this, and this might be a bad idea. Please feel free to reject. It was just easy to put this up as a PR.
@ntabris would something like this make your life easier? @fjetter is this not dumb?