Adjust popen timeouts for testing #8848
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This popen utility is often used in our CLI tests. The timeouts here are however not well adjusted to our overall test timeouts. Particularly if this is used inside of an async gen_test / gen_cluster test these timeouts do not match since the gen_cluster default test timeout is 30s.
Therefore, the async test timeout of 30s will always win over this popen timeout but timeouts should be hierarchical since they otherwise overshadow problems. The test
test_nanny_worker_port_range_too_many_workers_raises
for instance is failing intermittently on CI but there is no way to tell where or why it is stuck because the async timeout hits before anything else is happening.Generally, 30s and 10s for a process termination / kill is way too generous so I suggest to dial both of them down a bit