Labeled comprehension channel axis #381
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? Admins can comment |
|
add to allowlist
gpuCI ***@***.***> schrieb am Fr. 12. Juli 2024 um 14:58:
… Can one of the admins verify this patch?
Admins can comment ok to test to allow this one PR to run or add to
allowlist to allow all future PRs from the same author to run.
—
Reply to this email directly, view it on GitHub
<#381 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC7SWBB3O7L7RKIFQYAIZJDZL7HIDAVCNFSM6AAAAABKY4IG56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRVGUZDQMBYGA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
@joshua-gould I'd agree that supporting a channel axis could be useful here. However I've just seen that this isn't implemented upstream in Would you have opinions here @GenevieveBuckley @jakirkham ? |
|
Could we try raising an issue upstream with SciPy and see if there is interest in this feature? Maybe this is something @joshua-gould could help with 🙂 |
|
Fixed up merge conflicts here to pick up recent CI fixes Hope that is ok Please feel free to tweak further as needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support trailing channel axis in labeled_comprehension