Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dask version to 2022.2.1 #205

Merged
merged 3 commits into from
Feb 28, 2022
Merged

Update Dask version to 2022.2.1 #205

merged 3 commits into from
Feb 28, 2022

Conversation

jsignell
Copy link
Member

@jsignell jsignell commented Feb 25, 2022

The last package is building on conda-forge shortly, so I figured I'd put this up.

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsignell. This should be good to go once 2022.2.1 lands on conda-forge

@jsignell jsignell added the automerge PRs with this label will be auto merged on passing CI label Feb 25, 2022
@jsignell
Copy link
Member Author

closing in favor of #206

@jsignell jsignell closed this Feb 26, 2022
@jsignell jsignell deleted the 2022.2.1 branch February 26, 2022 20:16
@jsignell jsignell restored the 2022.2.1 branch February 28, 2022 14:50
@jsignell jsignell reopened this Feb 28, 2022
@jsignell
Copy link
Member Author

@jacobtomlinson it looks like the 3.8 base build is failing. I'm not quite sure how to go about debugging.

@jacobtomlinson
Copy link
Member

The error says No module named 'pip' which is a little strange. I've rerun the checks to see if it is a transient error.

@jsignell
Copy link
Member Author

Yeah I tested moving the python install up into the top line and it seems to work better locally. Can you see if that change looks sane to you?

@@ -10,10 +10,8 @@ ENV PATH /opt/conda/bin:$PATH
ENV PYTHON_VERSION=${python}
ENV DASK_VERSION=${release}

RUN conda install --yes nomkl cytoolz cmake \
&& conda install --yes mamba \
RUN conda install --yes -c conda-forge nomkl cytoolz cmake mamba python=${PYTHON_VERSION} \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the python install up, and added conda-forge to this line to make sure we don't have different channels.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm that doesn't seem to have quite done it.

@jsignell jsignell mentioned this pull request Feb 28, 2022
1 task
Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating the base image version did the trick -- thanks @jsignell!

@jrbourbeau jrbourbeau merged commit c9c8738 into dask:main Feb 28, 2022
@jsignell
Copy link
Member Author

Thanks @jrbourbeau!!

@jakirkham
Copy link
Member

There is an autoupdate bot that will make update PRs here

That said, it misses a few details that we haven't managed to sort out yet ( #197 ) ( #183 ) ( #180 )

@jsignell
Copy link
Member Author

There is an autoupdate bot that will make update PRs here

That said, it misses a few details that we haven't managed to sort out yet ( #197 ) ( #183 ) ( #180 )

yep! I mildly tried to fix the bot, but I think that would require knowing the previous version which I guess we could hard code or pull from main? I did not get very far...

@jsignell jsignell deleted the 2022.2.1 branch February 28, 2022 20:45
@jakirkham
Copy link
Member

Yeah I have as well, but I think there was something I wasn't getting right about how the regex got applied

@jacobtomlinson
Copy link
Member

Thanks for handling this folks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge PRs with this label will be auto merged on passing CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants