Skip to content

chore: move fuzz profile settings to workspace root#501

Open
xdustinface wants to merge 1 commit intov0.42-devfrom
fix/fuzz-profile-warning
Open

chore: move fuzz profile settings to workspace root#501
xdustinface wants to merge 1 commit intov0.42-devfrom
fix/fuzz-profile-warning

Conversation

@xdustinface
Copy link
Collaborator

@xdustinface xdustinface commented Mar 8, 2026

Fix the long existing cargo warning:

warning: profiles for the non root package will be ignored, specify profiles at the workspace root:
 package:   /Users/kevin/GIT/rust-dashcore/fuzz/Cargo.toml
 workspace: /Users/kevin/GIT/rust-dashcore/Cargo.toml

Profile settings in non-root packages are ignored by Cargo. Move codegen-units to the workspace root's per-package profile override and remove the redundant [profile.release] section from fuzz/Cargo.toml. The lto and panic settings already match the workspace defaults.

Summary by CodeRabbit

  • Chores
    • Optimized build configuration for release builds to improve compilation efficiency.
    • Updated fuzzing test configuration to use default build profile settings.

Fix the long existing cargo warning:

```
warning: profiles for the non root package will be ignored, specify profiles at the workspace root:
 package:   /Users/kevin/GIT/rust-dashcore/fuzz/Cargo.toml
 workspace: /Users/kevin/GIT/rust-dashcore/Cargo.toml
```

Profile settings in non-root packages are ignored by Cargo.
Move `codegen-units` to the workspace root's per-package profile
override and remove the redundant `[profile.release]` section
from `fuzz/Cargo.toml`. The `lto` and `panic` settings already match
the workspace defaults.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 8, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: be3a8bfe-18d8-486c-8ce9-d23ac4962169

📥 Commits

Reviewing files that changed from the base of the PR and between ebba180 and 3c5727c.

📒 Files selected for processing (2)
  • Cargo.toml
  • fuzz/Cargo.toml
💤 Files with no reviewable changes (1)
  • fuzz/Cargo.toml

📝 Walkthrough

Walkthrough

The pull request modifies the build configuration for the dash-fuzz package. The main Cargo.toml adds a codegen-units = 16 setting to the dash-fuzz release profile, while fuzz/Cargo.toml removes its custom release profile section entirely, reverting to default behavior.

Changes

Cohort / File(s) Summary
Build Configuration
Cargo.toml
Added codegen-units = 16 to [profile.release.package.dash-fuzz] section for parallelized code generation.
Fuzz Profile Cleanup
fuzz/Cargo.toml
Removed entire [profile.release] section with custom LTO and codegen settings, reverting to default release profile behavior.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Hopping through configs with careful precision,
Codegen units dance in parallel division,
One package optimized, one profile set free,
Build times get faster for you and for me!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: move fuzz profile settings to workspace root' clearly and concisely describes the main change: relocating fuzz profile configuration to the workspace root Cargo.toml file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/fuzz-profile-warning

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Mar 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.84%. Comparing base (ebba180) to head (3c5727c).

Additional details and impacted files
@@            Coverage Diff             @@
##           v0.42-dev     #501   +/-   ##
==========================================
  Coverage      66.83%   66.84%           
==========================================
  Files            313      313           
  Lines          64878    64878           
==========================================
+ Hits           43363    43366    +3     
+ Misses         21515    21512    -3     
Flag Coverage Δ *Carryforward flag
core 74.90% <ø> (ø)
dash-network 74.90% <ø> (ø) Carriedforward from ebba180
dash-network-ffi 34.74% <ø> (ø) Carriedforward from ebba180
dash-spv 68.18% <ø> (ø) Carriedforward from ebba180
dash-spv-ffi 34.74% <ø> (ø) Carriedforward from ebba180
dashcore 74.90% <ø> (ø) Carriedforward from ebba180
dashcore-private 74.90% <ø> (ø) Carriedforward from ebba180
dashcore-rpc 19.92% <ø> (ø) Carriedforward from ebba180
dashcore-rpc-json 19.92% <ø> (ø) Carriedforward from ebba180
dashcore_hashes 74.90% <ø> (ø) Carriedforward from ebba180
ffi 37.43% <ø> (ø)
key-wallet 65.58% <ø> (ø) Carriedforward from ebba180
key-wallet-ffi 34.74% <ø> (ø) Carriedforward from ebba180
key-wallet-manager 65.58% <ø> (ø) Carriedforward from ebba180
rpc 19.92% <ø> (ø)
spv 81.02% <ø> (+0.02%) ⬆️
wallet 65.58% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant