Skip to content

refactor: rename Dash network entries to Mainnet#500

Draft
xdustinface wants to merge 1 commit intochore/fix-network-docsfrom
fix/dash-mainnet
Draft

refactor: rename Dash network entries to Mainnet#500
xdustinface wants to merge 1 commit intochore/fix-network-docsfrom
fix/dash-mainnet

Conversation

@xdustinface
Copy link
Collaborator

Align the network names with Dash Core. Finally! This bugged me since i started to work on this repo haha.

Based on:

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 7, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6186913e-1c13-4588-81be-4283f5c516cc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/dash-mainnet

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Mar 7, 2026

Codecov Report

❌ Patch coverage is 72.77228% with 55 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.98%. Comparing base (b8a8fc5) to head (864ab58).

Files with missing lines Patch % Lines
dash/src/address.rs 67.64% 11 Missing ⚠️
key-wallet/src/bip38.rs 0.00% 9 Missing ⚠️
key-wallet/src/derivation_slip10.rs 16.66% 5 Missing ⚠️
key-wallet/src/bip32.rs 92.30% 4 Missing ⚠️
dash-spv-ffi/src/platform_integration.rs 0.00% 3 Missing ⚠️
key-wallet/src/account/account_type.rs 40.00% 3 Missing ⚠️
dash-spv-ffi/src/bin/ffi_cli.rs 0.00% 2 Missing ⚠️
dash-spv-ffi/src/config.rs 0.00% 2 Missing ⚠️
dash-spv/src/network/discovery.rs 0.00% 2 Missing ⚠️
dash/src/consensus/params.rs 0.00% 2 Missing ⚠️
... and 10 more
Additional details and impacted files
@@                    Coverage Diff                     @@
##           chore/fix-network-docs     #500      +/-   ##
==========================================================
- Coverage                   63.99%   63.98%   -0.01%     
==========================================================
  Files                         313      313              
  Lines                       64914    64915       +1     
==========================================================
- Hits                        41540    41537       -3     
- Misses                      23374    23378       +4     
Flag Coverage Δ *Carryforward flag
core 74.93% <80.48%> (-0.01%) ⬇️
dash-network 74.91% <ø> (-0.01%) ⬇️ Carriedforward from b8a8fc5
dash-network-ffi 34.76% <ø> (+0.02%) ⬆️ Carriedforward from b8a8fc5
dash-spv 68.17% <ø> (-0.02%) ⬇️ Carriedforward from b8a8fc5
dash-spv-ffi 34.76% <ø> (+0.02%) ⬆️ Carriedforward from b8a8fc5
dashcore 74.91% <ø> (-0.01%) ⬇️ Carriedforward from b8a8fc5
dashcore-private 74.91% <ø> (-0.01%) ⬇️ Carriedforward from b8a8fc5
dashcore-rpc 19.92% <ø> (ø) Carriedforward from b8a8fc5
dashcore-rpc-json 19.92% <ø> (ø) Carriedforward from b8a8fc5
dashcore_hashes 74.91% <ø> (-0.01%) ⬇️ Carriedforward from b8a8fc5
ffi 33.51% <27.77%> (-0.02%) ⬇️
key-wallet 65.53% <ø> (-0.05%) ⬇️ Carriedforward from b8a8fc5
key-wallet-ffi 34.76% <ø> (+0.02%) ⬆️ Carriedforward from b8a8fc5
key-wallet-manager 65.53% <ø> (-0.05%) ⬇️ Carriedforward from b8a8fc5
rpc 19.92% <ø> (ø)
spv 68.11% <78.94%> (-0.08%) ⬇️
wallet 65.57% <73.49%> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
dash-spv/src/chain/chain_work.rs 77.86% <100.00%> (ø)
dash-spv/src/client/config.rs 92.45% <100.00%> (ø)
dash-spv/src/client/config_test.rs 100.00% <100.00%> (ø)
dash-spv/src/mempool_filter.rs 84.64% <100.00%> (ø)
dash-spv/src/validation/header.rs 95.95% <100.00%> (ø)
dash/src/blockdata/constants.rs 100.00% <100.00%> (ø)
dash/src/blockdata/transaction/mod.rs 86.15% <100.00%> (ø)
dash/src/blockdata/transaction/outpoint.rs 77.50% <ø> (ø)
dash/src/crypto/key.rs 76.33% <100.00%> (ø)
dash/src/crypto/sighash.rs 65.27% <100.00%> (ø)
... and 28 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant