Skip to content

chore(key-wallet): drop unnecesary codebase complexity removing the bincode dependency#498

Draft
ZocoLini wants to merge 1 commit intov0.42-devfrom
chore/drop-key-wallet-bincode
Draft

chore(key-wallet): drop unnecesary codebase complexity removing the bincode dependency#498
ZocoLini wants to merge 1 commit intov0.42-devfrom
chore/drop-key-wallet-bincode

Conversation

@ZocoLini
Copy link
Collaborator

@ZocoLini ZocoLini commented Mar 6, 2026

No description provided.

@ZocoLini ZocoLini marked this pull request as draft March 6, 2026 20:26
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 6, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 76fd3aa3-2986-4cef-a458-e743c548202e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/drop-key-wallet-bincode

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

❌ Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.31%. Comparing base (f74c43e) to head (19e8895).

Files with missing lines Patch % Lines
key-wallet-manager/src/wallet_manager/mod.rs 55.55% 4 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           v0.42-dev     #498      +/-   ##
=============================================
+ Coverage      63.05%   64.31%   +1.26%     
=============================================
  Files            313      313              
  Lines          64878    64244     -634     
=============================================
+ Hits           40907    41321     +414     
+ Misses         23971    22923    -1048     
Flag Coverage Δ *Carryforward flag
core 74.90% <ø> (ø)
dash-network 74.90% <ø> (ø) Carriedforward from f74c43e
dash-network-ffi 34.74% <ø> (ø) Carriedforward from f74c43e
dash-spv 68.18% <ø> (ø) Carriedforward from f74c43e
dash-spv-ffi 34.74% <ø> (ø) Carriedforward from f74c43e
dashcore 74.90% <ø> (ø) Carriedforward from f74c43e
dashcore-private 74.90% <ø> (ø) Carriedforward from f74c43e
dashcore-rpc 19.92% <ø> (ø) Carriedforward from f74c43e
dashcore-rpc-json 19.92% <ø> (ø) Carriedforward from f74c43e
dashcore_hashes 74.90% <ø> (ø) Carriedforward from f74c43e
ffi 36.03% <ø> (+1.29%) ⬆️
key-wallet 65.99% <ø> (+0.40%) ⬆️ Carriedforward from f74c43e
key-wallet-ffi 34.74% <ø> (ø) Carriedforward from f74c43e
key-wallet-manager 65.99% <ø> (+0.40%) ⬆️ Carriedforward from f74c43e
rpc 19.92% <ø> (ø)
spv 68.18% <ø> (ø)
wallet 64.98% <55.55%> (-0.60%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
key-wallet-ffi/src/wallet_manager.rs 64.51% <ø> (+11.69%) ⬆️
key-wallet/src/account/account_collection.rs 57.61% <ø> (+0.43%) ⬆️
key-wallet/src/account/account_type.rs 50.27% <ø> (+0.54%) ⬆️
key-wallet/src/account/bls_account.rs 55.59% <ø> (+1.77%) ⬆️
key-wallet/src/account/eddsa_account.rs 58.16% <ø> (+1.67%) ⬆️
key-wallet/src/account/mod.rs 63.00% <ø> (+0.20%) ⬆️
key-wallet/src/bip32.rs 85.19% <ø> (+4.54%) ⬆️
key-wallet/src/derivation_bls_bip32.rs 92.17% <ø> (+0.62%) ⬆️
key-wallet/src/derivation_slip10.rs 44.05% <ø> (-1.02%) ⬇️
key-wallet/src/dip9.rs 6.52% <ø> (+0.13%) ⬆️
... and 11 more

... and 13 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant