Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: cache Rust dependencies build as a docker layer #1900

Merged
merged 5 commits into from
Sep 6, 2024

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Jun 21, 2024

Issue being fixed or feature implemented

Rust building system is not leveraging docker layer cache since the layer with actual build is invalidating by copying project files. If anything is changed we build from scratch (from layer cache perspective).

What was done?

  • Build dependencies as a separate layer with cargo chief

How Has This Been Tested?

Building locally and modifyng files. The dependecies buildin layer stay cached.

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov added this to the v1.0.0 milestone Jun 21, 2024
Dockerfile Show resolved Hide resolved
lklimek
lklimek previously approved these changes Jul 1, 2024
Copy link
Contributor

@lklimek lklimek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider moving it to 1.1

@shumkov shumkov changed the base branch from v1.0-dev to master August 25, 2024 06:05
@shumkov shumkov dismissed lklimek’s stale review August 25, 2024 06:05

The base branch was changed.

@shumkov shumkov requested a review from antouhou as a code owner August 25, 2024 06:05
@shumkov shumkov changed the base branch from master to v1.3-dev September 5, 2024 12:26
@shumkov shumkov self-assigned this Sep 5, 2024
@lklimek lklimek self-requested a review September 5, 2024 12:26
@shumkov shumkov merged commit 6e2a4db into v1.3-dev Sep 6, 2024
19 checks passed
@shumkov shumkov deleted the build/docker-layer-cache-for-rust branch September 6, 2024 10:54
@thephez thephez modified the milestones: v1.0.0, v1.3.0 Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants