Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(usernames): submit request UI #674

Open
wants to merge 11 commits into
base: feat/coinjoin
Choose a base branch
from
Open

feat(usernames): submit request UI #674

wants to merge 11 commits into from

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented Nov 18, 2024

Issue being fixed or feature implemented

We need to re-work the UI for submitting username requests, verifying with links, confirmation dialog, etc.

What was done?

  • UI changes
  • Some CoinJoin fixes
  • Committed XCode lint changes

How Has This Been Tested?

QA

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Syn-McJ Syn-McJ requested a review from pankcuf November 18, 2024 10:33
@Syn-McJ Syn-McJ self-assigned this Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pankcuf pankcuf Awaiting requested review from pankcuf

Assignees

@Syn-McJ Syn-McJ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Syn-McJ @pankcuf