refactor: update lock annotations for GovernanceStore, CGovernanceManager and CGovernanceStore, move away from RecursiveMutexes
#6849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CCoinJoinClientQueueManager is conditionally initialized, we will be deref'ing a nullptr if relay_txes is false.
We are discarding the value of `ObjName::Sign()` so we are assuming it is always valid, let's codify that assumption with an assert, something we generate should hold valid to ourselves.
Review with `git log -p -n1 --color-moved=dimmed_zebra`.
Support for P2SH proposals was introduced in Dash Core 0.18, we don't have to worry about antagonizing those peers as they're multiple hard forks behind us.
`cmapVoteToObject` isn't (de)ser'ed so we move it to the manager and don't consider it for the mutex
Review with `git log -p -n1 --color-moved=dimmed_zebra`.
This will simplify our work in subsequent commits. Review with `git log -p -n1 --color-moved=dimmed_zebra`.
Needed to make the next commit easier to follow.
Currently, the LOCKs aren't guarding anything. Variables protected were based on existing LOCK'ing patterns (i.e. (de)ser'ed variables except for m_obj).
✅ No Merge Conflicts DetectedThis PR currently has no conflicts with other open PRs. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Information
GovernanceSigner, dropRelay()s and use periodic relay instead, minor cleanup #6838Breaking Changes
None expected.
Checklist