refactor: move CSigSharesManager to ActiveContext, drop CActiveMasternodeManager from CSigSharesManager
#6841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wallet should not concern itself with masternode mode state. Client side mixing is not available for masternodes and masternodes are no longer allowed to have the collateral in their own local wallet, drop it.
We don't initialize mn_activeman in TestingSetup so we don't need to set `connOptions.m_active_masternode`
ActiveContext is going to host all entities are part of masternode mode (i.e. used by a node if it is an active masternode) and is required to separate interactive (i.e. networking-driven) portions of consensus from portions that can be done non-interactively/offline.
Now that CCoinJoinServer is conditionally initialized, we can remove checks that assumed its unconditional existence.
We initialize the masternode mode context later and as it's explicitly networking-heavy, we can move CConnman and PeerManager back into the ctor and trim down the arguments list a fair bit. Effectively reverts 82d1aed.
Giving write access of CRecoveredSigsDb to an external manager isn't great but we have to do this if we want to drop CActiveMasternodeManager from CSigSharesManager Review with `git log -p -n1 --color-moved=dimmed_zebra`.
As ProcessRecoveredSig() triggers a NotifyRecoveredSig() notification, we can stick the RelayRecoveredSig() into CSigSharesManager and have the relay request processed through the notification interface instead, lets us finally drop CActiveMasternodeManager from CSigSharesManager.
|
|
This pull request has conflicts, please rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Information
fMasternodeModeglobal, create new context for masternode mode-only logic (ActiveContext), move spun-off signers and EHF signals handler #6828{evo,llmq}/types.h#6839Breaking Changes
None expected.
Checklist