perf: temporary cache for consequent calls of CDeterministicMNList for historical blocks #6734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughA conditional block was added to the method 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (9)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
at first, I haven't planned to get this one merged, because I assumed that it improves only |
…r historical blocks It speeds ups blocks's Undo up to 10x. It speeds up RPC `protx diff` up to 9x
knst
force-pushed
the
perf-rpc-protx-diff
branch
from
4de63d1 to
30a9b2e
Compare
Comment on lines
+1072
to
+1078
| if (snapshot.GetHeight() % 32 == 0) { | ||
| // Add this temporary mini-snapshot to cache. | ||
| // This extra cached mn-list helps to improve performance of GetListForBlock | ||
| // for close blocks, because in the worst cases each of them requires to retrieve | ||
| // and apply up to 575 diffs | ||
| mnListsCache.emplace(snapshot.GetBlockHash(), snapshot); | ||
| } |
There was a problem hiding this comment.
- Consider Making Cache Interval Configurable
- The hardcoded value 32 could be a named constant or configurable parameter
static constexpr int MINI_SNAPSHOT_INTERVAL = 32;
if (snapshot.GetHeight() % MINI_SNAPSHOT_INTERVAL == 0) {
|
Consider:
|
diff --git a/src/evo/deterministicmns.cpp b/src/evo/deterministicmns.cpp
index 921a119642..3f2dab1d3e 100644
--- a/src/evo/deterministicmns.cpp
+++ b/src/evo/deterministicmns.cpp
@@ -16,6 +16,7 @@
#include <consensus/validation.h>
#include <deploymentstatus.h>
#include <messagesigner.h>
+#include <node/blockstorage.h>
#include <script/standard.h>
#include <stats/client.h>
#include <uint256.h>
@@ -26,6 +27,8 @@
#include <optional>
#include <memory>
+using node::fReindex;
+
static const std::string DB_LIST_SNAPSHOT = "dmn_S3";
static const std::string DB_LIST_DIFF = "dmn_D3";
@@ -780,7 +783,7 @@ CDeterministicMNList CDeterministicMNManager::GetListForBlockInternal(gsl::not_n
for (const auto& diffIndex : listDiffIndexes) {
const auto& diff = mnListDiffsCache.at(diffIndex->GetBlockHash());
snapshot.ApplyDiff(diffIndex, diff);
- if (snapshot.GetHeight() % 32 == 0) {
+ if (!fReindex && (snapshot.GetHeight() % 32 == 0)) {
// Add this temporary mini-snapshot to cache.
// This extra cached mn-list helps to improve performance of GetListForBlock
// for close blocks, because in the worst cases each of them requires to retrieve
Agree
Adding unit tests here feels like an overkill tbh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Each call of
CDeterministicMNManager::GetListForBlockfor historical block can require up to 575 diff applying from snapshot.Consequent calls for close blocks repeat this calculation twice.
What was done?
This PR abuses
mnListsCacheby adding mini-snapshot each 32 blocks between snapshots in database (each 576 blocks).Downside of this solution: extra RAM usage.
Though, this cache is cleaned every 10 seconds by
CDeterministicMNManager::DoMaintenance, so, the RAM usage is temporary.How Has This Been Tested?
It speeds up RPC
protx diffup to 8x.develop:PR:
It speeds ups blocks's Undo up to 10x; measured by calling
invalidateblock blockhashwhere blockhash is distant block, far from the tip (500+).Breaking Changes
N/A
Checklist: