feat: introduce type-flexible NetInfoEntry to allow non-CService entries, use in MnNetInfo
#6629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notes: - CPendingDsaRequest will now track the ProTx hash and will resolve the primary address just before sending the request. - Validation of the expected masternode address matching the peer has been deduplicated. Failure created a debug log entry for DSCOMPLETE (though not for DSSTATUSUPDATE or DSFINALTX) but now it will happen silently.
In the next commit, we are going to enforce validation the moment we to set values. That will break this test because this test makes two errors. - It tries to use non-mainnet ports on BasicTestingSetup (which is mainnet), resolved by using RegTest. - It constructs the IP 0.0.0.0, which is not a routable address, resolved by counting from 1 onwards.
GetEntries does nothing except wrap the one singular entry we have into a set. Right now this functionally changes nothing but this lets us change code to adapt to the possibility that a MnNetInfo-like object could store more than one value at some point down the line.
Currently this does nothing different since both MnNetInfo and CService serialize the same (and we only store one entry) but will allow us to swap with an extended addresses capable variant down the line.
Also, ProRegTx allows an empty netInfo, ProUpServTx does not, so we should check that ProUpServTx::netInfo isn't empty.
5 tasks
kwvg
changed the title
NetInfoEntry to allow non-CService entries, use in MnNetInfoNetInfoEntry to allow non-CService entries, use in MnNetInfo
|
This pull request has conflicts, please rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Information
MnNetInfo, set some groundwork for managing multiple entries #6627Breaking Changes
Work in progress
Checklist