Update iron scavenging by detritus #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # doc/phys_pkgs/darwin_iron.rst
# Conflicts: # pkg/darwin/darwin_cons.F # Conflicts: # pkg/darwin/darwin_cons.F # Conflicts: # pkg/darwin/darwin_cons.F
# Conflicts: # pkg/darwin/darwin_forcing.F # Conflicts: # pkg/darwin/darwin_forcing.F # Conflicts: # pkg/darwin/darwin_forcing.F # Conflicts: # pkg/darwin/darwin_forcing.F
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes does this PR introduce?
Update formulation of iron scavening in terms of particles (#define DARWIN_PART_SCAV).
What is the current behaviour?
Iron scavenging is parameterized in terms of POC only and the conversion to particle weight is wrong.
What is the new behaviour
Scavenging is parameterized in terms of POC, POSi and PIC. Reasonable conversion factors are provided.
Does this PR introduce a breaking change?
Yes. In order to recover the previous formulation, parameters need to be changed from their defaults.
Other Information
Docs are here.