Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): drop Go 1.21 support #29

Merged
merged 1 commit into from
Jan 13, 2025
Merged

feat(build): drop Go 1.21 support #29

merged 1 commit into from
Jan 13, 2025

Conversation

karasz
Copy link
Contributor

@karasz karasz commented Jan 12, 2025

Summary by CodeRabbit

  • Chores
    • Updated Go version from 1.21 to 1.22 across project configuration files.
    • Updated GitHub Actions workflow to use Go versions 1.22 and 1.23.
    • Updated linting tool versions to align with the new Go version.
    • Modified Renovate configuration to allow Go version 1.22.
    • Introduced new linter configuration to improve code quality checks.

@karasz karasz requested a review from amery January 12, 2025 18:53
Copy link

coderabbitai bot commented Jan 12, 2025

Walkthrough

This pull request updates the project's Go version from 1.21 to 1.22 across multiple configuration files. The changes consistently modify the Go version in the GitHub Actions workflow, Makefile, go.mod, and Renovate configuration. The update ensures that the project is configured to use Go version 1.22, removing references to the older 1.21 version while maintaining the existing project structure and tooling.

Changes

File Change Summary
.github/workflows/build.yml Removed Go 1.21 from matrix, leaving only 1.22 and 1.23
Makefile Updated tool versions to reference Go 1.22 for GOLANGCI_LINT and REVIVE
go.mod Changed Go version from 1.21 to 1.22
renovate.json Updated allowed Golang version from 1.21 to 1.22
.golangci.yml Introduced a new configuration for linters with specific settings and rules

Possibly related PRs

Poem

🐰 Hop, hop, Go version's new,
From 1.21 to 1.22 we brew!
Workflows dance, configs align,
A rabbit's code update so fine!
Version bump with coding glee! 🚀


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@amery
Copy link
Contributor

amery commented Jan 12, 2025

we need to update the build system here first. The .golangci file is missing so automated tests are incomplete

Copy link
Contributor

@amery amery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add update the build system first as golangci-lint config seems missing

Signed-off-by: Nagy Károly Gábriel <[email protected]>
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
.golangci.yml (1)

40-62: Consider adding modern linters for enhanced code quality.

While the current set of linters is good, consider adding these modern linters:

  • gocritic: Provides many useful checks
  • godot: Ensures consistent comment formatting
  • wrapcheck: Ensures errors are wrapped with additional context
  • tparallel: Detects incorrect usage of t.Parallel()

Apply this diff to add them:

  enable:
    - copyloopvar
    - dupl
    - errcheck
+   - gocritic
+   - godot
    - gofmt
    - goimports
    - gosimple
    - govet
    - ineffassign
    - lll
    - misspell
    - nakedret
    - prealloc
    - revive
    - staticcheck
    - tparallel
    - typecheck
    - unconvert
    - unparam
    - unused
+   - wrapcheck
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 534b9f7 and 5b40022.

📒 Files selected for processing (5)
  • .github/workflows/build.yml (1 hunks)
  • .golangci.yml (1 hunks)
  • Makefile (1 hunks)
  • go.mod (1 hunks)
  • renovate.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (4)
  • go.mod
  • renovate.json
  • .github/workflows/build.yml
  • Makefile
🔇 Additional comments (3)
.golangci.yml (3)

1-3: LGTM! Good configuration for CI performance.

The run configuration with a 5-minute deadline and parallel execution is well-balanced for CI performance.


8-39: LGTM! Comprehensive revive configuration.

The revive configuration includes a well-thought-out set of rules, combining both recommended and additional rules that promote code quality.


1-62: Verify linter compatibility with Go 1.22.

Since this PR drops Go 1.21 support, we should verify that all enabled linters are compatible with Go 1.22.

@amery amery merged commit f7e44bc into main Jan 13, 2025
7 checks passed
@amery amery deleted the pr-karasz-go122 branch January 13, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants