-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(build): drop Go 1.21 support #29
Conversation
WalkthroughThis pull request updates the project's Go version from 1.21 to 1.22 across multiple configuration files. The changes consistently modify the Go version in the GitHub Actions workflow, Makefile, go.mod, and Renovate configuration. The update ensures that the project is configured to use Go version 1.22, removing references to the older 1.21 version while maintaining the existing project structure and tooling. Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
we need to update the build system here first. The .golangci file is missing so automated tests are incomplete |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add update the build system first as golangci-lint config seems missing
Signed-off-by: Nagy Károly Gábriel <[email protected]>
534b9f7
to
5b40022
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.golangci.yml (1)
40-62
: Consider adding modern linters for enhanced code quality.While the current set of linters is good, consider adding these modern linters:
gocritic
: Provides many useful checksgodot
: Ensures consistent comment formattingwrapcheck
: Ensures errors are wrapped with additional contexttparallel
: Detects incorrect usage of t.Parallel()Apply this diff to add them:
enable: - copyloopvar - dupl - errcheck + - gocritic + - godot - gofmt - goimports - gosimple - govet - ineffassign - lll - misspell - nakedret - prealloc - revive - staticcheck - tparallel - typecheck - unconvert - unparam - unused + - wrapcheck
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
.github/workflows/build.yml
(1 hunks).golangci.yml
(1 hunks)Makefile
(1 hunks)go.mod
(1 hunks)renovate.json
(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (4)
- go.mod
- renovate.json
- .github/workflows/build.yml
- Makefile
🔇 Additional comments (3)
.golangci.yml (3)
1-3
: LGTM! Good configuration for CI performance.The run configuration with a 5-minute deadline and parallel execution is well-balanced for CI performance.
8-39
: LGTM! Comprehensive revive configuration.The revive configuration includes a well-thought-out set of rules, combining both recommended and additional rules that promote code quality.
1-62
: Verify linter compatibility with Go 1.22.Since this PR drops Go 1.21 support, we should verify that all enabled linters are compatible with Go 1.22.
Summary by CodeRabbit