Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): drop Go 1.21 support #97

Merged
merged 2 commits into from
Jan 12, 2025
Merged

feat(build): drop Go 1.21 support #97

merged 2 commits into from
Jan 12, 2025

Conversation

amery
Copy link
Contributor

@amery amery commented Jan 10, 2025

Summary by CodeRabbit

Release Notes

  • Chores

    • Updated Go version from 1.21 to 1.22 across project configuration files.
    • Updated build workflow to support Go versions 1.22 and 1.23.
    • Modified development tooling configurations to use newer Go version.
  • Maintenance

    • Updated linting and code quality tool versions to align with Go 1.22.
    • Added a new linter, copyloopvar, and removed exportloopref from the linter configuration.

These changes ensure compatibility with the latest Go programming language version and improve overall project toolchain configuration.

Copy link

coderabbitai bot commented Jan 10, 2025

Walkthrough

The pull request introduces an update to the project's Go version, transitioning from Go 1.21 to Go 1.22. This change is reflected across several configuration files, including the GitHub Actions workflow, Makefile, go.mod, and Renovate configuration. The modifications ensure that the build processes and tool versions are aligned with the newer Go version, updating both the build matrix and version constraints accordingly.

Changes

File Change Summary
.github/workflows/build.yml Removed Go 1.21 from build matrix, now using Go 1.22 and 1.23
Makefile Updated GOLANGCI_LINT_VERSION to 1.22 and REVIVE_VERSION to 1.22 while changing GOLANGCI_LINT_VERSION from v1.59 to v1.63.4
go.mod Changed Go version from 1.21 to 1.22
renovate.json Updated allowedVersions from 1.21 to 1.22
.golangci.yml Added copyloopvar linter, removed exportloopref linter

Possibly related PRs

Suggested labels

enhancement

Suggested reviewers

  • karasz

Poem

🐰 Hop, hop, Go version's new!
From 1.21 to 1.22 we flew
Workflows dance, configs align
Renovate smiles, everything's fine
A rabbit's leap to coding delight! 🚀


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3e576ae and f704e5e.

📒 Files selected for processing (1)
  • Makefile (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • Makefile

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@amery amery requested a review from karasz January 10, 2025 17:54
Copy link

deepsource-io bot commented Jan 10, 2025

Here's the code health analysis summary for commits 4f09fe2..f704e5e. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Shell LogoShell✅ SuccessView Check ↗
DeepSource Go LogoGo✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link
Contributor

@karasz karasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karasz karasz merged commit 61fe9cf into main Jan 12, 2025
10 checks passed
@karasz karasz deleted the pr-amery-go122 branch January 12, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants