Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: DateRange throws exception if start > end #62

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

rafamizes
Copy link
Member

Closes #61

@rafamizes rafamizes added the refactor A code change that neither fixes a bug nor adds a feature label Nov 28, 2023
@rafamizes rafamizes self-assigned this Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6d8629a) 93.05% compared to head (bd5704c) 93.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
+ Coverage   93.05%   93.24%   +0.18%     
==========================================
  Files          11       11              
  Lines          72       74       +2     
==========================================
+ Hits           67       69       +2     
  Misses          5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rafamizes rafamizes merged commit 34b5bef into dartoos-dev:master Nov 28, 2023
3 checks passed
@rafamizes rafamizes deleted the issue_61 branch November 28, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace the assertion with a suitable exception in the DateRange class
1 participant