initial improvements #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukas-h
reviewed
Feb 29, 2024
jsiedentop
force-pushed
the
improvements
branch
from
793b07d
to
3688138
Compare
This was
linked to
issues
Feb 29, 2024
Open
|
Just a quick note, before I forget it: I think we should have validation in different modes:
|
jsiedentop
commented
Mar 15, 2024
| @@ -1,7 +1,7 @@ | |||
| # GeoTypes | |||
| A lightweight library for GeoJSON data types available dart and flutter. | |||
| A lightweight GeoJson library for dart and Flutter. | |||
jsiedentop
commented
Mar 15, 2024
|
|
||
| // "bbox": [-10.0, -10.0, 10.0, 10.0], | ||
| List<ValidationHint> validateBoundingBox(dynamic bbox) { | ||
| final hints = <ValidationHint>[]; |
There was a problem hiding this comment.
replace hints with direct returns
jsiedentop
commented
Mar 15, 2024
| /// "prop1": 0.0 | ||
| /// } | ||
| /// }] | ||
| /// } |
There was a problem hiding this comment.
add ``` at the end
jsiedentop
commented
Mar 15, 2024
| final hints = <ValidationHint>[]; | ||
|
|
||
| if (json["type"] != "FeatureCollection") { | ||
| hints.add(ValidationHint.geometryTypeInvalid); |
There was a problem hiding this comment.
should be ValidationHint.geoJsonObjectTypeInvalid
jsiedentop
commented
Mar 15, 2024
| if (features == null || features is! List) { | ||
| hints.add(ValidationHint.featureCollectionFeaturesMustBeAList); | ||
| } else { | ||
| if (features.isNotEmpty) { |
jsiedentop
commented
Mar 15, 2024
| } else if (!json.containsKey("type")) { | ||
| hints.add(ValidationHint.geometryMustHaveType); | ||
| } else { | ||
| final validators = { |
There was a problem hiding this comment.
use type <String,List Function(dynamic)>
jsiedentop
commented
Mar 15, 2024
| } else if (!json.containsKey("type")) { | ||
| hints.add(ValidationHint.geometryMustHaveType); | ||
| } else { | ||
| final validators = { |
jsiedentop
commented
Mar 15, 2024
| hints.add(ValidationHint.geometryCollectionGeometriesShouldHaveItems); | ||
| } | ||
| for (final geometry in geometries) { | ||
| hints.addAll(validateGeometry(geometry)); |
There was a problem hiding this comment.
here we need a geometryCollectionShouldNotBeNested
jsiedentop
commented
Mar 15, 2024
| /// validatePosition([115, -35, 100]); | ||
| /// ``` | ||
|
|
||
| // ToDo: remove null and List check and use strong type here! |
jsiedentop
commented
Mar 15, 2024
| if (position.length < 2) { | ||
| errors.add(ValidationHint.positionMustContainAtLeast2Elements); | ||
| } else if (position.length > 3) { | ||
| // SHOULD NOT extend positions beyond three elements |
jsiedentop
commented
Mar 15, 2024
| ValidationHint.geometryCollectionGeometriesMustBeAList, | ||
| ValidationHint.geometryMustBeAnObject, | ||
| ValidationHint.geometryMustHaveType, | ||
| ValidationHint.geometryTypeInvalid, |
There was a problem hiding this comment.
we need geometryTypeInvalid AND geoJsonTypeInvalid
jsiedentop
commented
Mar 15, 2024
|
|
||
| final second = Feature(bbox: bbox).toJson(); | ||
| final jsonString = JsonEncoder.withIndent(" ").convert(second); | ||
| print(jsonString); |
jsiedentop
commented
Mar 15, 2024
| expect(second.containsKey('bbox'), true); | ||
| }); | ||
|
|
||
| test('GeometryCollection', () { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.