Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for setting custom DDS port #2546

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Allow for setting custom DDS port #2546

wants to merge 6 commits into from

Conversation

bkonyi
Copy link
Collaborator

@bkonyi bkonyi commented Dec 16, 2024

@bkonyi bkonyi requested a review from jyameo December 16, 2024 21:17
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 16, 2024 •
edited
Loading

Package publishing

Package Version Status Publish tag (post-merge)
package:dwds 24.2.1 ready to publish dwds-v24.2.1
package:frontend_server_client 4.0.0 already published at pub.dev
package:webdev 3.7.1-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

jyameo
jyameo approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@jyameo jyameo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good to me once that failure issue is resolved! Also quick question for my understanding, where are the changes to client.js coming from?

@bkonyi bkonyi mentioned this pull request Dec 19, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyameo jyameo jyameo approved these changes

Assignees
No one assigned
Labels
package:dwds prepare-release publish-ignore-warnings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkonyi @jyameo