Replace site-shared submodule with git dependencies #6898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 439ba2e): https://dart-dev--pr6898-fix-remove-site-shared-submodule-c44b8mko.web.app |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
This makes me soooo happy! Can we get ride of all the submodule silliness comments in https://github.com/dart-lang/site-www/blob/main/README.md too? |
Thanks for pushing me to do this! Nice that we can do this now that everything used is just a Dart package. I forgot to push that commit before this landed. I opened #6904 with the doc updates and workflow cleanup. |
mit-mit
pushed a commit
that referenced
this pull request
Sep 26, 2025
Follow up that I forgot to push to the #6898 PR. - Stops setting up the submodule in GitHub workflows. - Stops checking if the submodule is up to date with dependabot. - Doesn't try to initialize the submodule in Firebase Studio. - Remove the instructions around the submodule from the README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
inject_dartpad.dart.jsscript needs to be inlined now that site-shared is not a submodule. However, this is temporary as we plan to replace this with a new Dart API directly from a Jaspr component. The API is added in dart-lang/site-shared#247.