Fix: Adding absolute paths to build.py and gn.py #59798
Conversation
Changed build.py and gn.py to allow for differing absolute paths. This case may occurr when building dart-sdk under Linux signed-off-by: Thomas Rahimi <[email protected]>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at: https://dart-review.googlesource.com/c/sdk/+/402282 Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly. Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR). |
|
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
1 similar comment
|
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
Added another relative path variable to allow build in non standard environments signed-off-by: Thomas Rahimi <[email protected]>
|
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
1 similar comment
|
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
|
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
1 similar comment
|
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
|
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
1 similar comment
|
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
|
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
1 similar comment
|
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
|
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
1 similar comment
|
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
|
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
1 similar comment
|
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
|
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
1 similar comment
|
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
|
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
1 similar comment
|
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
|
Issue was assigned in https://dart-review.googlesource.com/c/sdk/+/402282 |
|
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
1 similar comment
|
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
…by gclient. The overall aim is to be able to build dart from source without the necessity for binary files present in the build process. signed-off-by: Thomas Rahimi <[email protected]>
|
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
1 similar comment
|
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
signed-off-by: Thomas Rahimi <[email protected]>
|
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
1 similar comment
|
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
…ay, that the need for binary dart packages within the build process can be omitted. The reason to submit this fix is, that Linux distributions requiring the complete build to be based on source code may also not accept to receive binary packages as part of the build process (cf. OpenSUSE project packaging guidelines [https://en.opensuse.org/openSUSE:Packaging_guidelines]). The current commit introduces a new target OS, which changes the settings of the BUILD.gn used for building dart-sdk. signed-off-by: Thomas Rahimi <[email protected]>
|
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
1 similar comment
|
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
|
https://dart-review.googlesource.com/c/sdk/+/402282 has been updated with the latest commits from this pull request. |
|
@thomasrahimi please see the comments on https://dart-review.googlesource.com/c/sdk/+/402282. |
Hello, |
|
@thomasrahimi are you still working on this? If so, please respons to comments directly in the review tool https://dart-review.googlesource.com/c/sdk/+/402282 and update the PR contents per the feedback. |
|
As mentioned in the googlesource.com comments, I will rework the approach introducing separate options to not break any existing solutions. This also allows to include possible adaptions, such as for the resulting gni files |
Changed build.py and gn.py to allow for differing absolute paths. This case may occur when building dart-sdk under Linux
signed-off-by: Thomas Rahimi [email protected]