Only mark package swiftpm incompatible when pluginClass is present. #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @loic-sharma |
isoos
reviewed
Nov 19, 2024
isoos
approved these changes
Nov 19, 2024
|
This is not a very future-proof test, since eventually we expect no plugins to have a podspec. I would recommend skipping if the relevant platform section of the pubspec doesn't contain This line is an example of what indicates that there must be native code. Plugins without that line either have native code in a dependency, or have no native code for that platform (e.g., use FFI). |
|
That makes a lot more sense. Updated. |
sigurdm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1419