Fix error reporting #3162
Merged
Fix error reporting #3162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. Coverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR). API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
|
devoncarew
approved these changes
Mar 3, 2025
| @@ -17,6 +17,7 @@ void main() { | |||
| // This code should be kept up-to-date with | |||
| // https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/web/bootstrap.dart#L236. | |||
| const kBootstrapFlutterCode = r''' | |||
| import 'package:flutter/foundation.dart'; | |||
There was a problem hiding this comment.
nit: sort after the dart: imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for displaying Dart or Flutter error messages in console and lets you drag to adjust the size. If an error message has been received since the user last cleared the console, we show that. If there's only normal output, we show that.
One potential issue with this approach: If there's an error being displayed, you can't go back to view view console output until you clear the console. We could add a tab bar to switch between the two, but this was the best I could do without adding extra UI components that take up space.
fixes #3008
fixes #3148