-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dartpad_ui] Add splash screen #3089
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@parlough Hi! What do you think about this PR? |
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. Coverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR). API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
|
@devoncarew Hi! I'm sorry if I'm tagging you. But could you please tell me how I should deal with this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! I like that you've moved the index.html styles into a new file - I think that helps with readability.
Wrt the white flash at startup, I do see it now myself; I expect that it's noticeable when using the dark theme. We probably don't need the dart icon as part of the splash screen, and, we may want to make the exit animation for the splash screen shorter as it would otherwise delay visibility by a 1/2 sec.
You may generally want to start with an issue instead of a PR for feature contributions - it would help save you time if we decide against the feature in general. But I'm probably not the right reviewer; I'll bump you over to @johnpryan and @parlough.
} | ||
|
||
#splash.light { | ||
background-color: #f5f5f7; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this color is the color we'd settle into after we've started up in the light theme?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that's right.
} | ||
|
||
#splash.dark { | ||
background-color: #1f2833; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same with this with the dark theme?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep.
You're right, I was a bit rushed with the PR though. I'll start with issues next time. |
Added a simple splash screen so that when you open dartpad.dev you don't have to look at a white screen. 🙂
Implemented with mobile devices and theme change in mind.
Mobile Demo
Screen.Recording.2024-11-09.at.21.27.45.mov
Desktop Demo
Screen.Recording.2024-11-09.at.21.25.07.mov
Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.