Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use an assets folder for the app's fonts #2981

Closed
wants to merge 1 commit into from
Closed

Conversation

devoncarew
Copy link
Member


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@devoncarew devoncarew changed the title use as assets folder use an assets folder for the app's fonts Jun 4, 2024
@parlough
Copy link
Member

parlough commented Jun 4, 2024

I've tried another approach in #2982 that moves the frame's prepared assets to its own directory, as it seems the root of the problem was its AssetManifest, which overrided the one generated for DartPad proper.

@devoncarew
Copy link
Member Author

Closing in favor of #2982.

@devoncarew devoncarew closed this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants