Add custom context menu for diagnostics #2916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoncarew
approved these changes
Apr 1, 2024
There was a problem hiding this comment.
Looks good!
Happy for this PR to land as is, but here's a potential tweak. On hover, we could make two action buttons visible on the right hand side; one an info or external link icon, and one a copy icon. I think this solution would have improved discoverability.
I like that idea, and it likely provides a better keyboard-only experience too! I worried the UI would get crowded, but only showing up on hover/focus seems like a good way to manage that. I'll land this for now as implementing that will require some more UI considerations, but I opened #2925 to explore it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A potential solution for #2877 that surfaces a custom context menu when right clicking a diagnostic message, allowing developers to copy the error message or view the full documentation.
It might make sense to copy a more complete message than just the issue, similar to what
dart analyzeoutputs, so let me know what you think is most useful :)Closes #2877