Skip to content

Use process.kill instead of process manager killPid #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Use process.kill instead of process manager killPid #303

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0905a5d
Use process.kill instead of process manager killPid
gspencergoog Oct 22, 2025
354589b
Kill all the child processes
gspencergoog Oct 22, 2025
e1f66f7
Fix tests.
gspencergoog Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkgs/dart_mcp_server/lib/src/mixins/flutter_launcher.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ base mixin FlutterLauncherSupport
} catch (e, s) {
log(LoggingLevel.error, 'Error launching Flutter application: $e\n$s');
if (process != null) {
processManager.killPid(process.pid);
process.kill();
// The exitCode handler will perform the rest of the cleanup.
}
return CallToolResult(
Expand Down
1 change: 0 additions & 1 deletion pkgs/dart_mcp_server/test/tools/flutter_launcher_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,6 @@ void main() {
'TimeoutException',
]),
);
test.expect(mockProcessManager.killedPids, [processPid]);
Copy link
Contributor

@jakemac53 jakemac53 Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to look for the mocked processes here and then check if they were killed


server.shutdown();
client.shutdown();
Expand Down