Skip to content

Conversation

jacqueminv
Copy link

No description provided.

@jacqueminv
Copy link
Author

Fixes #237

@jacqueminv
Copy link
Author

Hi @darrenburns,
Is there any way to have this one reviewed please?

@darrenburns
Copy link
Owner

Sorry for the delay. I don't think this is correct, as we want to use OSC 52 in tmux on MacOS in terminals other than Apple Terminal. Isn't this going to prevent that?

@jacqueminv
Copy link
Author

Using OSC 52 in tmux on MacOS is not working according to the bug report and to my experience. This fixes it for me. I'm using iTerm. But I'm glad to validate on a different configurations, what am I missing?

@jacqueminv
Copy link
Author

/ping @darrenburns

@darrenburns
Copy link
Owner

I think the solution here will work for you but will change the behaviour in other cases. This will prevent OSC52 clipboard support from working in tmux even when it's enabled.

For iTerm2, if you enable OSC52, Posting should probably just work without any changes.

The tmux issue probably needs to be fully solved via a new config option in Posting, where users can choose between using OSC52 or using pyperclip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants