Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On MacOS, main menu items display the title of their sub-menu rather than their own title #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TheBrokenRail
Copy link

}
}
}
return _title;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that how it works on macOS?

That is, does it return the original title if the submenu title is nil?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a Mac to test with, but it seems to be reasonable fallback behavior if it is nil. Is there any situation where someone would set the menu title and not the submenu title and expect it to show up blank?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know; but this is Apple we're talking about, they're not known for always doing the sanest thing :)

This shouldn't be hard to check...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To check all you should have to do is modify the example program from #679 so that the parent menus items have titles, not the submenus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Main menu menus have no labels
2 participants