Use rawprepare-cropped dimensions #17099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshannoschwalm
added
feature: enhancement
jenshannoschwalm
force-pushed
the
raw_width_49
branch
2 times, most recently
from
bb06d97
to
ead9b34
Compare
jenshannoschwalm
force-pushed
the
raw_width_49
branch
from
ead9b34
to
2fbec67
Compare
jenshannoschwalm
force-pushed
the
raw_width_49
branch
2 times, most recently
from
59b581c
to
05d323f
Compare
Currently we use the cropping **defaults** for calculation of actually used sensor dimensions / ratio instead of what rawprepare actually does, there we have the (hidden by default) sliders defining the real crops. Although unlikely it is a perfectly valid usecase to change those either by presets or UI. This pr ensures the actually used p_width & p_height in dev->image_storage are 1. correctly initialized while loading an image 2. updated while committing parameters in rawprepare 3. used wherever we want them, examples are lens, masks, crop & ashift if we want to keep sensor ratio. For most images this won't do anything, expect subtle improvements if rawprepare does something different than default crops, also code is more clear.
jenshannoschwalm
force-pushed
the
raw_width_49
branch
from
05d323f
to
61475fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we use the cropping defaults for calculation of actually used sensor dimensions / ratio instead of what rawprepare actually does, there we have the (hidden by default) sliders defining the real crops.
Although unlikely it is a perfectly valid usecase to change those either by presets or UI.
This pr ensures the actually used p_width & p_height in dev->image_storage are
For most images this won't do anything, expect subtle improvements if rawprepare does something different than default crops, also code is more clear.