Skip to content

refactor(settings): tab the settings window and cut what it did not need #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arzafran merged 13 commits into from
Jul 31, 2026
Merged

refactor(settings): tab the settings window and cut what it did not need #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0300f91
refactor(settings): drop the sidebar tint controls from Settings
arzafran Jul 31, 2026
f9b0b89
refactor(settings): drop the workspace color pickers and palette editor
arzafran Jul 31, 2026
b2dd1f6
fix(settings): localize the two App rows that shipped bare strings
arzafran Jul 31, 2026
29ed091
feat(settings): split the settings window into six tabs
arzafran Jul 31, 2026
c8d47f9
refactor(settings): delete the keep-workspace-open-on-last-surface to…
arzafran Jul 31, 2026
57ded5c
refactor(settings): delete the focus-pane-on-first-click toggle
arzafran Jul 31, 2026
e08d401
refactor(settings): delete the rename-selects-existing-name toggle
arzafran Jul 31, 2026
36e37ed
test: file the socket-driven perf harnesses with the other socket tests
arzafran Jul 31, 2026
f6ecd55
test: drop the tests for the removed keep-workspace-open preference
arzafran Jul 31, 2026
859dc3a
refactor(settings): stop duplicating the import hint inside Settings
arzafran Jul 31, 2026
1e99bea
Merge pull request #233 from darkroomengineering/refactor/settings-br…
arzafran Jul 31, 2026
47c529f
refactor(pairing): one way in on each side instead of three
arzafran Jul 31, 2026
1b26c22
Merge pull request #234 from darkroomengineering/refactor/pairing-cle…
arzafran Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,7 +689,7 @@ jobs:
PROGRAMA_LAG_MAX_CHURN_P95_MS=35 \
PROGRAMA_LAG_KEY_EVENTS=180 \
PROGRAMA_LAG_KEY_COMBO="${{ inputs.lag_combo || 'up' }}" \
python3 tests/test_workspace_churn_up_arrow_lag.py
python3 tests_v2/test_workspace_churn_up_arrow_lag.py

# On-demand only. This measures the refresh call itself with an in-process
# timer rather than an end-to-end socket round trip, because that round trip
Expand Down Expand Up @@ -739,7 +739,7 @@ jobs:
# where nobody can read it. That cost a full four-run cycle to learn nothing.
if ! PROGRAMA_SOCKET_PATH="$SOCK" \
PROGRAMA_REFRESH_COST_KEY_EVENTS=400 \
python3 tests/test_text_input_refresh_cost.py | tee -a "$GITHUB_STEP_SUMMARY"; then
python3 tests_v2/test_text_input_refresh_cost.py | tee -a "$GITHUB_STEP_SUMMARY"; then
echo "--- app still running? ---"
pgrep -x "Programa DEV" >/dev/null && echo "yes" || echo "NO - it exited"
echo "--- socket present at $SOCK? ---"
Expand Down
Loading
Loading