Fix Django 2.0 compatibility problems #651
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
D3X
reviewed
Dec 5, 2017
| @@ -16,9 +21,12 @@ | |||
| from suit.config import get_config | |||
|
|
|||
| register = template.Library() | |||
| if django.VERSION >= (2, 0, 0, 'final', 0): | |||
There was a problem hiding this comment.
assignment_tag has been deprecated since 1.9.
Also, you can compare against a "coarse" version, not a very specific one. Makes it a little more readable.
if django.VERSION < (1, 9):
simple_tag = register.assignment_tag
else:
simple_tag = register.simple_tag| 'django.contrib.auth.middleware.AuthenticationMiddleware', | ||
| 'django.contrib.messages.middleware.MessageMiddleware', | ||
| ) | ||
| if django.VERSION >= (2, 0, 0, 'final', 0): |
There was a problem hiding this comment.
The new-style middleware can be used since 1.10.
iamkingalvarado
approved these changes
Dec 6, 2017
amureki
reviewed
Dec 28, 2017
There was a problem hiding this comment.
@kidsdev thank you for PR!
I would update travis configuration to be sure that tests are passing.
|
I tested this, and it works for me. 👍 |
jerzyk
reviewed
Feb 2, 2018
|
|
||
| try: | ||
| from django.urls import reverse, resolve | ||
| except: |
There was a problem hiding this comment.
this is far too broad, I suggest to narrow it to ImportError exception:
try:
...
except ImportError:
...
jerzyk
reviewed
Feb 2, 2018
| out_tpl = '<div class="datetime">%s</div>' | ||
| return mark_safe(out_tpl % html) | ||
|
|
||
| # def format_output(self, rendered_widgets): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.