Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing package dependency declaration. Added Eclipse files to gitignore. #549

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

chrisspen
Copy link

No description provided.

@darklow
Copy link
Owner

darklow commented Oct 20, 2016

Thanks.
Although I am not sure about adding Django as a dependency.
There is a rarely the case when someone installs django-suit first and one more thing - I really don't like fact that when adding Django as dependency and running pip install -U django-suit it forces to install newest Django version as well which is not wanted at all.

@shulcsm
Copy link
Collaborator

shulcsm commented Oct 21, 2016

Editor meta file ignores should be kept in .git/info/exclude since they are specific to your personal preferences/environment.

@chrisspen
Copy link
Author

@shulcsm, No, anything that should never be committed under any circumstances should be added to .gitignore. To state otherwise is to imply that you might want to someday commit these files, which will never happen. Even Github includes these in their auto-generated .gitignore.

@chrisspen
Copy link
Author

chrisspen commented Oct 21, 2016

@darklow, That's a fair point. I've run into the upgrade issue myself, which is a known bug/issue.

pypa/pip#304

The argument in favor of the current behavior, is that pip will only upgrade to the most recent version supported by all dependencies. Since you don't list Django as a dependency at all, much less a maximum version, if another package lists Django as a dependency and runs an upgrade, it'll upgrade to the most recent version. If you state the version as, say, Django<=1.9, then it shouldn't upgrade past that.

So yes, you're avoiding one problem by not listing any dependencies, but you're potentially creating a much bigger problem in the long run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants