refactor prices+fees #259
Open
refactor prices+fees #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- All fees (except balancer) are specified to `1e6` (Uniswap v3 standard) as base - Fees are now included in costs - Removed fixed point calculations and replaced with f64 directly - Balancer fee must be u64 (bug fix) - Consistent error type for unsupported tokens - Uniswap v3 had the spot pricing backwards
henopied
force-pushed
the
fee-refactor
branch
from
f4d801b to
9899f1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I noticed some inconsistencies with how pricing and fees work between different AMMs. This PR aims to unify them and solve a couple bugs I spotted.
Solution
1e6(Uniswap v3 standard) as basePR Checklist