Skip to content

[1.17][JAVA]: Update java conversation quickstart#1287

Merged
alicejgibbons merged 1 commit intodapr:release-1.17from
javier-aliaga:java-conversation-update
Feb 17, 2026
Merged

[1.17][JAVA]: Update java conversation quickstart#1287
alicejgibbons merged 1 commit intodapr:release-1.17from
javier-aliaga:java-conversation-update

Conversation

@javier-aliaga
Copy link

@javier-aliaga javier-aliaga commented Feb 11, 2026

Description

Please explain the changes you've made

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1284

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

@javier-aliaga javier-aliaga requested review from a team as code owners February 11, 2026 12:18
@javier-aliaga javier-aliaga marked this pull request as draft February 11, 2026 12:18
@javier-aliaga javier-aliaga force-pushed the java-conversation-update branch 2 times, most recently from ac1023d to 318b94b Compare February 17, 2026 11:45
Signed-off-by: Javier Aliaga <javier@diagrid.io>
@javier-aliaga javier-aliaga force-pushed the java-conversation-update branch from 318b94b to 007d5a9 Compare February 17, 2026 11:48
@javier-aliaga javier-aliaga marked this pull request as ready for review February 17, 2026 11:49

private static void printPromptDetails(ConversationResultPromptUsageDetails completionDetails) {
// Display completion token breakdown if available
System.out.println("Prompt Token Details:");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add all these into the quickstart? We try and make the quickstarts as close to eachother as possible. So this one should be as close to the HTTP example as possible #1276

}
}

UsageUtils.printDetails(CONVERSATION_COMPONENT_NAME, conversationResponse.getOutputs().get(0));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did none of the output change for this version of the quickstart? Ie do we need to update the mechanical markdown tests or readme at all to ensure we are calling out what changed?

https://github.com/dapr/quickstarts/pull/1276/changes#diff-2ae25a5b5cc8d067edd02e317037813e7b62c71f6644ab0c1bc4e0553ebbca73R66

@javier-aliaga javier-aliaga changed the title feat: Update java conversation quickstart [1.17][JAVA]: Update java conversation quickstart Feb 17, 2026
@alicejgibbons alicejgibbons merged commit 54c5970 into dapr:release-1.17 Feb 17, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments