[1.17][JAVA]: Update java conversation quickstart#1287
Merged
alicejgibbons merged 1 commit intodapr:release-1.17from Feb 17, 2026
Merged
[1.17][JAVA]: Update java conversation quickstart#1287alicejgibbons merged 1 commit intodapr:release-1.17from
alicejgibbons merged 1 commit intodapr:release-1.17from
Conversation
ac1023d to
318b94b
Compare
Signed-off-by: Javier Aliaga <javier@diagrid.io>
318b94b to
007d5a9
Compare
alicejgibbons
requested changes
Feb 17, 2026
|
|
||
| private static void printPromptDetails(ConversationResultPromptUsageDetails completionDetails) { | ||
| // Display completion token breakdown if available | ||
| System.out.println("Prompt Token Details:"); |
Contributor
There was a problem hiding this comment.
Do we need to add all these into the quickstart? We try and make the quickstarts as close to eachother as possible. So this one should be as close to the HTTP example as possible #1276
| } | ||
| } | ||
|
|
||
| UsageUtils.printDetails(CONVERSATION_COMPONENT_NAME, conversationResponse.getOutputs().get(0)); |
Contributor
There was a problem hiding this comment.
Did none of the output change for this version of the quickstart? Ie do we need to update the mechanical markdown tests or readme at all to ensure we are calling out what changed?
javier-aliaga
commented
Feb 17, 2026
conversation/java/sdk/conversation/src/main/java/com/service/UsageUtils.java
Show resolved
Hide resolved
alicejgibbons
approved these changes
Feb 17, 2026
This was referenced Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you've made
Issue reference
We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1284
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: