Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes data argument optional on transactional delete #752

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

elena-kolevska
Copy link
Contributor

Description

This PR makes the data parameter not required in TransactionalStateOperation for DELETE operations.

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@elena-kolevska elena-kolevska requested review from a team as code owners November 4, 2024 11:07
Copy link
Member

@berndverst berndverst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix type check

tox -e type tox -e mypy

Signed-off-by: Elena Kolevska <[email protected]>
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.03%. Comparing base (bffb749) to head (e203d14).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #752      +/-   ##
==========================================
- Coverage   86.63%   86.03%   -0.60%     
==========================================
  Files          84       87       +3     
  Lines        4473     4783     +310     
==========================================
+ Hits         3875     4115     +240     
- Misses        598      668      +70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elena-kolevska
Copy link
Contributor Author

Fixed. Thanks @berndverst

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants