Events: type Batcher value & ensure queue order #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Batcher to allow for typed value types. Update Batcher and Queue to execute values in order they were added. Signed-off-by: joshvanl <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
=======================================
Coverage 79.93% 79.94%
=======================================
Files 56 56
Lines 4351 4382 +31
=======================================
+ Hits 3478 3503 +25
- Misses 728 733 +5
- Partials 145 146 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: joshvanl <[email protected]>
yaron2
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Batcher to allow for typed value types.
Update Batcher and Queue to execute values in order they were added.