Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds events/batch/singular #85

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JoshVanL
Copy link
Contributor

Adds Singular Batcher which treat all events as the same event key. Subscribers provide a function when subscribing which will be executed once the batch triggers.

Used by dapr/components-contrib#3363

Adds Singular Batcher which treat all events as the same event key.
Subscribers provide a function when subscribing which will be executed
once the batch triggers.

Signed-off-by: joshvanl <[email protected]>
@JoshVanL JoshVanL requested review from a team as code owners February 26, 2024 12:55
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.95%. Comparing base (9e733a3) to head (fa869e2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
+ Coverage   79.76%   79.95%   +0.18%     
==========================================
  Files          55       56       +1     
  Lines        4339     4365      +26     
==========================================
+ Hits         3461     3490      +29     
+ Misses        732      730       -2     
+ Partials      146      145       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ItalyPaleAle
ItalyPaleAle previously approved these changes Feb 26, 2024
Copy link
Contributor

@ItalyPaleAle ItalyPaleAle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love the name Singular, but this is a bit of a nit.

Approved, feel free to merge if you don't have further changes to make

events/batcher/singuler.go Outdated Show resolved Hide resolved
Signed-off-by: Alessandro (Ale) Segala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants