Adds generic ring #108
Open
Adds generic ring #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a generic implementation of the stdblib ring buffer so that each ring `Value` can be a concrete type. https://pkg.go.dev/container/ring Adds `Len() int` and `Keys() []K` func to the generic Map cmap. Changes `events/queue` Processor `Queueable` to be an exported type. No functional change, but consumed types should be exported. Signed-off-by: joshvanl <[email protected]>
Signed-off-by: joshvanl <[email protected]>
Signed-off-by: joshvanl <[email protected]>
Signed-off-by: joshvanl <[email protected]>
Signed-off-by: joshvanl <[email protected]>
Comment on lines
+1
to
+3
| // Copyright 2009 The Go Authors. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style | ||
| // license that can be found in the LICENSE file. |
There was a problem hiding this comment.
Do we need to add a mention about Dapr editing the file? I don't know what the convention is here.
There was a problem hiding this comment.
That's done 3 lines down. I assumed the editor being Dapr was assumed through context.
There was a problem hiding this comment.
Yeah, I saw, was just wondering if the name Dapr needs to be mentioned, I genuinely don't know if that's the case.
elena-kolevska
approved these changes
Nov 12, 2024
Signed-off-by: joshvanl <[email protected]>
elena-kolevska
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a generic implementation of the stdblib ring buffer so that each ring
Valuecan be a concrete type.https://pkg.go.dev/container/ring
Adds a
ring/Bufferedwhich implements a ring which buffers nodes, and expands/contracts based on live nodes. Used to reduce memory allocations.Adds
Len() intandKeys() []Kfunc to the generic Map cmap.Changes
events/queueProcessorQueueableto be an exported type. No functional change, but consumed types should be exported.