Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: upgrade lint & go #649

Merged
merged 11 commits into from
Nov 14, 2024
Merged

chore!: upgrade lint & go #649

merged 11 commits into from
Nov 14, 2024

Conversation

mikeee
Copy link
Member

@mikeee mikeee commented Nov 7, 2024

Description

Issue reference

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

BREAKING CHANGE: State consistency, concurrency and operation types are now int32 sized.
Panic on an overflow conversion for a proto duration

Signed-off-by: Mike Nguyen <[email protected]>
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 6 lines in your changes missing coverage. Please review.

Project coverage is 62.23%. Comparing base (6c59092) to head (a609257).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
client/actor.go 0.00% 2 Missing ⚠️
client/state.go 71.42% 1 Missing and 1 partial ⚠️
service/http/scheduling.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #649      +/-   ##
==========================================
- Coverage   62.52%   62.23%   -0.30%     
==========================================
  Files          56       56              
  Lines        4139     4189      +50     
==========================================
+ Hits         2588     2607      +19     
- Misses       1425     1454      +29     
- Partials      126      128       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikeee mikeee marked this pull request as ready for review November 7, 2024 16:06
@mikeee mikeee requested review from a team as code owners November 7, 2024 16:06
@mikeee mikeee marked this pull request as draft November 7, 2024 16:07
@mikeee mikeee marked this pull request as ready for review November 7, 2024 20:02
@mikeee mikeee changed the title chore!: upgrade lint chore!: upgrade lint & go Nov 7, 2024
@yaron2 yaron2 merged commit 59acca4 into dapr:main Nov 14, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants