Added Server.Unwrap function#162
Open
handicraftsman wants to merge 4 commits intodapr:mainfrom
Open
Conversation
Member
|
@skyao please review this |
Member
This function exposures the underlying implementation details, it is realy NOT a clean way as you say. It breaks the design, can we find a better way? |
Author
|
I don't know, for this specific case it would be a good idea to implement adding middlewares on top of the internal handler, while not exposing the values like i did in my commit. Or it should be possible to start treating the returned values as public, while also making sure that you cannot use the |
Member
|
@skyao what do you think? |
Member
I have given my comments: I understand the requirement from , but I think we need find a better way, which won't break the design. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a tiny commit, mostly for internal use.
I did it to support adding middlewares (such as logging, which is my case) over the http.ServeMux generated by the Dapr SDK.
It is probably not the cleanest way to do that though, as you still need to cast the
daprd.NewServiceWithMux()output withs.(*daprd.Server)