Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Facility to provide interface while registering actors #1350
base: master
Are you sure you want to change the base?
Facility to provide interface while registering actors #1350
Changes from 2 commits
5cc8189
87eedfd
404da07
c463186
c836bc4
41656aa
d06803e
49c9f3b
3985537
ec1ba43
20d9d4a
400b6eb
c72eab5
225130b
00c700b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we force the use of
IActor
interface we can add a Diagnostics to block the compilation when the derived class contains methods that doesn't returnTask<T>
. Similar to what is done in the actors' source generator for theCancellationToken
(example)I usually don't like to find out particularities from documentation, if possible I prefer my editor to guide me.
What do you think about it?