-
Notifications
You must be signed in to change notification settings - Fork 759
docs: add jobs overwrite flag #4646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Javier Aliaga <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@javier-aliaga - Commented. A few things
-
Please put the code issue into the docs issue. I have added it in this case (Don't overwrite jobs using same name dapr#8402)
-
Let's use this PR to update docs overview here https://docs.dapr.io/developing-applications/building-blocks/jobs/jobs-overview/
- Under Features we really should say that the primary feature here is to create, get and delete jobs. This can be one paragraph, but in that paragraph you should mention that an existing job cannot be overwritten unless specific indicated. Write something and I will review this
- The first sentence here is now wrong I presume https://docs.dapr.io/developing-applications/building-blocks/jobs/jobs-overview/ under "Schedule jobs across multiple replicas" - where is says "When you create a job, it replaces any existing job with the same name." Should now say "When you create a job, it does not replace an existing job with the same name, unless you explicitly set the 'overwrite' flag"
- Remove the "waiting on code" label once this code is merged.
daprdocs/content/en/developing-applications/building-blocks/jobs/jobs-features-concepts.md
Outdated
Show resolved
Hide resolved
…bs/jobs-features-concepts.md Co-authored-by: Mark Fussell <[email protected]> Signed-off-by: Javier Aliaga <[email protected]>
Co-authored-by: Mark Fussell <[email protected]> Signed-off-by: Javier Aliaga <[email protected]>
Signed-off-by: Javier Aliaga <[email protected]>
daprdocs/content/en/developing-applications/building-blocks/jobs/jobs-features-concepts.md
Outdated
Show resolved
Hide resolved
…bs/jobs-features-concepts.md Co-authored-by: Josh van Leeuwen <[email protected]> Signed-off-by: Javier Aliaga <[email protected]>
daprdocs/content/en/developing-applications/building-blocks/jobs/jobs-overview.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/developing-applications/building-blocks/jobs/jobs-overview.md
Outdated
Show resolved
Hide resolved
…bs/jobs-overview.md Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: Javier Aliaga <[email protected]>
…bs/jobs-overview.md Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: Javier Aliaga <[email protected]>
daprdocs/content/en/developing-applications/building-blocks/jobs/jobs-overview.md
Outdated
Show resolved
Hide resolved
…bs/jobs-overview.md Signed-off-by: Mark Fussell <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Issue reference
Issue - dapr/dapr#8402
PR - dapr/dapr#8701