Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Create a file-based lockstore component #3418

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

moonorange
Copy link

@moonorange moonorange commented May 18, 2024

Description

Please explain the changes you've made

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Related PR and discussion

dapr/dapr#7631 (comment)

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

@moonorange
Copy link
Author

Hi, @elena-kolevska
I'd appreciate your early feedback to ensure I'm on the right track.
I am implementing an in-memory lock store similar to
https://github.com/dapr/components-contrib/blob/main/state/in-memory/in_memory.go.

Should I continue with this approach, or should I use files similar to
https://github.com/dapr/components-contrib/blob/main/secretstores/local/file/filestore.go ?

@elena-kolevska
Copy link
Contributor

Hi @moonorange , I'm happy to see your work on this!
Due to the nature of what we're trying to do here, a file-based lock will make more sense because it can be accessed by multiple applications.

@berndverst
Copy link
Member

I am one of the maintainers of this repository and I have no context for what this PR is about or which issue it is addressing.

Please first create a new issue in dapr/components-contrib that explains what feature or functionality is needed and why.

@moonorange moonorange changed the title [WIP] [WIP] Create a file-based lockstore component Jun 9, 2024
@moonorange
Copy link
Author

Hi @berndverst, I created a new issue for this PR
#3438

@yaron2
Copy link
Member

yaron2 commented Jun 17, 2024

@moonorange we are approaching code freeze, it'd be great if you got the PR ready for review this week. Thanks!

@yaron2
Copy link
Member

yaron2 commented Jun 26, 2024

Ping @moonorange

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants