-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kafka): add producer config capabilities for connections #3371
Conversation
Signed-off-by: Samantha Coyle <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]>
I can update docs after I get initial feedback here pls :) |
Signed-off-by: Samantha Coyle <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]>
Looks like main still has rabbit mq issues based on these test results |
Signed-off-by: Samantha Coyle <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]>
unrelated failure due to stable components certification test for bindings.rabbitmq and pubsub.rabbitmq |
ready! |
Signed-off-by: Samantha Coyle <[email protected]>
this is now a dependency: dapr/kit#88 |
Signed-off-by: Samantha Coyle <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]>
I've had a couple of issues with |
Signed-off-by: Samantha Coyle <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]>
ready |
Signed-off-by: Samantha Coyle <[email protected]>
Signed-off-by: Samantha Coyle <[email protected]>
ping @ItalyPaleAle ready :) |
ping for review please |
ready for review please |
Signed-off-by: Samantha Coyle <[email protected]>
…onents-contrib into feat-kafka-producer-configs
addressed feedback. Thanks @JoshVanL |
Signed-off-by: Samantha Coyle <[email protected]>
ready @ItalyPaleAle Thanks for the extra feedback! |
Description
For the sidecars using the existing kafka client configurations, after a connection has been closed by the client after the default connection idle timeout of 9 minutes, then if that sidecar goes to write and publish a message they will see a
write: broken pipe
err. This is due to the connection being deemed idle, but the sidecar has no idea, and so when it tries to publish, then it is doing so to a closed connection to which we see that error. It is quite confusing for end users, and so these metadata fields allow us to keep a connection alive and establish a refresh for the topic metadata such that the connection may be kept alive indefinitely if desired.Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: