Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #75 : changed transactions to use prepare/execute #103

Merged
merged 2 commits into from
Mar 9, 2021

Conversation

timongll
Copy link
Contributor

@timongll timongll commented Mar 8, 2021

Fixes issue #75: Changed a few simple transactions from nba-smart-contracts to use prepare/execute instead of prepare or none at all

@joshuahannan
Copy link
Collaborator

@timongll Thank you so much for working on these! Can you run the tests with make test also to make sure they pass?

@timongll
Copy link
Contributor Author

timongll commented Mar 9, 2021

@timongll Thank you so much for working on these! Can you run the tests with make test also to make sure they pass?

done

@timongll timongll changed the title changed transactions to use prepare/execute Fixes issue#75: changed transactions to use prepare/execute Mar 9, 2021
@timongll timongll changed the title Fixes issue#75: changed transactions to use prepare/execute Fixes issue #75 : changed transactions to use prepare/execute Mar 9, 2021
@timongll timongll changed the title Fixes issue #75 : changed transactions to use prepare/execute Fixes issue KEYWORD #75 : changed transactions to use prepare/execute Mar 9, 2021
@timongll timongll changed the title Fixes issue KEYWORD #75 : changed transactions to use prepare/execute Fixes issue #75 : changed transactions to use prepare/execute Mar 9, 2021
Copy link
Collaborator

@joshuahannan joshuahannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look great! Thank you for helping out. :)

@joshuahannan joshuahannan merged commit 23fb490 into dapperlabs:master Mar 9, 2021
@timongll timongll deleted the transaction_changes branch March 16, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants