Use adjusted gross income in withheld state income taxes (PolicyEngin…

…e#5053) * Add self-employment income to withheld state income taxes Fixes PolicyEngine#5041 * changelog * minor * Separate `takes_up_snap_if_eligible` variable * adj variables * tests * changelog * Fix errors in withheld income tax variables * Add coverage to dev deps * Bump Core * Fix test variables * chore: Disable Windows tests temporarily * fix: Remove Windows tests from PR, as well * fix: Remove Windows tests --------- Co-authored-by: vrathi101 <[email protected]> Co-authored-by: Nikhil Woodruff <[email protected]> Co-authored-by: Anthony Volk <[email protected]>
daphnehanse11 · Sep 27, 2024 · 75fece7 · 75fece7
1 parent 7ba8021
commit 75fece7
Show file tree

Hide file tree

Showing 91 changed files with 288 additions and 357 deletions.
diff --git a/.github/workflows/pr.yaml b/.github/workflows/pr.yaml
@@ -31,11 +31,8 @@ jobs:
       - name: Check version number has been properly updated
         run: .github/is-version-number-acceptable.sh
   Test:
-    runs-on: ${{ matrix.os }}
+    runs-on: ubuntu-latest
     continue-on-error: true
-    strategy:
-      matrix:
-        os: [ubuntu-latest, windows-latest]
     steps:
       - name: Checkout repo
         uses: actions/checkout@v4

diff --git a/.github/workflows/push.yaml b/.github/workflows/push.yaml
@@ -44,13 +44,10 @@ jobs:
           message: Update PolicyEngine US
           github_token: ${{ secrets.POLICYENGINE_GITHUB }}
   Test:
-    runs-on: ${{ matrix.os }}
+    runs-on: ubuntu-latest
     if: |
       (github.repository == 'PolicyEngine/policyengine-us')
       && (github.event.head_commit.message == 'Update PolicyEngine US')
-    strategy:
-      matrix:
-        os: [ubuntu-latest, windows-latest]
     steps:
       - name: Checkout repo
         uses: actions/checkout@v4

diff --git a/changelog_entry.yaml b/changelog_entry.yaml
@@ -0,0 +1,7 @@
+- bump: minor
+  changes:
+    added:
+    - Use adjusted gross income in withheld state income tax.
+    - Separate takes_up_snap_if_eligible variable from snap variable.
+    removed:
+    - Windows test runner.
diff --git a/policyengine_us/tests/policy/baseline/gov/states/al/tax/income/al_withheld_income_tax.yaml b/policyengine_us/tests/policy/baseline/gov/states/al/tax/income/al_withheld_income_tax.yaml
@@ -2,7 +2,7 @@
   period: 2022
   absolute_error_margin: 0.01
   input:
-    irs_employment_income: 10_000
+    adjusted_gross_income_person: 10_000
     filing_status: JOINT
     state_code: AL
   output:
@@ -12,7 +12,7 @@
   period: 2022
   absolute_error_margin: 0.01
   input:
-    irs_employment_income: 10_000
+    adjusted_gross_income_person: 10_000
     filing_status: SURVIVING_SPOUSE
     state_code: AL
   output:
@@ -22,7 +22,7 @@
   period: 2022
   absolute_error_margin: 0.01
   input:
-    irs_employment_income: 2_900
+    adjusted_gross_income_person: 2_900
     filing_status: SURVIVING_SPOUSE
     state_code: AL
   output:

diff --git a/policyengine_us/tests/policy/baseline/gov/states/ar/tax/income/ar_withheld_income_tax.yaml b/policyengine_us/tests/policy/baseline/gov/states/ar/tax/income/ar_withheld_income_tax.yaml
@@ -2,7 +2,7 @@
   period: 2022
   absolute_error_margin: 0.01
   input:
-    irs_employment_income: 15_000
+    adjusted_gross_income_person: 15_000
     filing_status: JOINT
     state_code: AR
   output:
@@ -12,7 +12,7 @@
   period: 2022
   absolute_error_margin: 0.01
   input:
-    irs_employment_income: 15_000
+    adjusted_gross_income_person: 15_000
     filing_status: SURVIVING_SPOUSE
     state_code: AR
   output:
@@ -22,7 +22,7 @@
   period: 2022
   absolute_error_margin: 0.01
   input:
-    irs_employment_income: 5_000
+    adjusted_gross_income_person: 5_000
     filing_status: SURVIVING_SPOUSE
     state_code: AR
   output:

diff --git a/policyengine_us/tests/policy/baseline/gov/states/az/tax/income/az_withheld_income_tax.yaml b/policyengine_us/tests/policy/baseline/gov/states/az/tax/income/az_withheld_income_tax.yaml
@@ -2,7 +2,7 @@
   period: 2022
   absolute_error_margin: 0.01
   input:
-    irs_employment_income: 15_000
+    adjusted_gross_income_person: 15_000
     filing_status: JOINT
     state_code: AZ
   output:
@@ -12,7 +12,7 @@
   period: 2022
   absolute_error_margin: 0.01
   input:
-    irs_employment_income: 15_000
+    adjusted_gross_income_person: 15_000
     filing_status: SURVIVING_SPOUSE
     state_code: AZ
   output:
@@ -22,7 +22,7 @@
   period: 2022
   absolute_error_margin: 0.01
   input:
-    irs_employment_income: 12_900
+    adjusted_gross_income_person: 12_900
     filing_status: SURVIVING_SPOUSE
     state_code: AZ
   output:

diff --git a/policyengine_us/tests/policy/baseline/gov/states/ca/tax/income/ca_withheld_income_tax.yaml b/policyengine_us/tests/policy/baseline/gov/states/ca/tax/income/ca_withheld_income_tax.yaml
@@ -2,7 +2,7 @@
   period: 2022
   absolute_error_margin: 0.01
   input:
-    irs_employment_income: 6_000
+    adjusted_gross_income_person: 6_000
     filing_status: JOINT
     state_code: CA
   output:
@@ -12,7 +12,7 @@
   period: 2022
   absolute_error_margin: 0.01
   input:
-    irs_employment_income: 6_000
+    adjusted_gross_income_person: 6_000
     filing_status: SURVIVING_SPOUSE
     state_code: CA
   output:
@@ -22,7 +22,7 @@
   period: 2022
   absolute_error_margin: 0.01
   input:
-    irs_employment_income: 5_000
+    adjusted_gross_income_person: 5_000
     filing_status: SURVIVING_SPOUSE
     state_code: CA
   output:

diff --git a/policyengine_us/tests/policy/baseline/gov/states/co/tax/income/co_withheld_income_tax.yaml b/policyengine_us/tests/policy/baseline/gov/states/co/tax/income/co_withheld_income_tax.yaml
@@ -2,7 +2,7 @@
   period: 2022
   absolute_error_margin: 0.01
   input:
-    irs_employment_income: 15_000
+    adjusted_gross_income_person: 15_000
     filing_status: JOINT
     state_code: CO
   output:
@@ -12,7 +12,7 @@
   period: 2022
   absolute_error_margin: 0.01
   input:
-    irs_employment_income: 15_000
+    adjusted_gross_income_person: 15_000
     filing_status: SURVIVING_SPOUSE
     state_code: CO
   output:
@@ -22,7 +22,7 @@
   period: 2022
   absolute_error_margin: 0.01
   input:
-    irs_employment_income: 12_000
+    adjusted_gross_income_person: 12_000
     filing_status: SURVIVING_SPOUSE
     state_code: CO
   output:

diff --git a/policyengine_us/tests/policy/baseline/gov/states/ct/tax/income/ct_withheld_income_tax.yaml b/policyengine_us/tests/policy/baseline/gov/states/ct/tax/income/ct_withheld_income_tax.yaml
@@ -2,7 +2,7 @@
   period: 2022
   absolute_error_margin: 0.01
   input:
-    irs_employment_income: 17_000
+    adjusted_gross_income_person: 17_000
     filing_status: JOINT
     state_code: CT
   output:
@@ -12,7 +12,7 @@
   period: 2022
   absolute_error_margin: 0.01
   input:
-    irs_employment_income: 17_000
+    adjusted_gross_income_person: 17_000
     filing_status: SURVIVING_SPOUSE
     state_code: CT
   output:
@@ -22,7 +22,7 @@
   period: 2022
   absolute_error_margin: 0.01
   input:
-    irs_employment_income: 14_000
+    adjusted_gross_income_person: 14_000
     filing_status: SURVIVING_SPOUSE
     state_code: CT
   output:

diff --git a/policyengine_us/tests/policy/baseline/gov/states/dc/tax/income/dc_withheld_income_tax.yaml b/policyengine_us/tests/policy/baseline/gov/states/dc/tax/income/dc_withheld_income_tax.yaml
@@ -2,7 +2,7 @@
   period: 2022
   absolute_error_margin: 0.01
   input:
-    irs_employment_income: 15_000
+    adjusted_gross_income_person: 15_000
     filing_status: JOINT
     state_code: DC
   output:
@@ -12,7 +12,7 @@
   period: 2022
   absolute_error_margin: 0.01
   input:
-    irs_employment_income: 15_000
+    adjusted_gross_income_person: 15_000
     filing_status: SURVIVING_SPOUSE
     state_code: DC
   output:
@@ -22,7 +22,7 @@
   period: 2022
   absolute_error_margin: 0.01
   input:
-    irs_employment_income: 12_000
+    adjusted_gross_income_person: 12_000
     filing_status: SURVIVING_SPOUSE
     state_code: DC
   output:

diff --git a/policyengine_us/tests/policy/baseline/gov/states/de/tax/income/de_withheld_income_tax.yaml b/policyengine_us/tests/policy/baseline/gov/states/de/tax/income/de_withheld_income_tax.yaml
@@ -2,7 +2,7 @@
   period: 2022
   absolute_error_margin: 0.01
   input:
-    irs_employment_income: 15_000
+    adjusted_gross_income_person: 15_000
     filing_status: JOINT
     state_code: DE
   output:
@@ -12,7 +12,7 @@
   period: 2022
   absolute_error_margin: 0.01
   input:
-    irs_employment_income: 15_000
+    adjusted_gross_income_person: 15_000
     filing_status: SURVIVING_SPOUSE
     state_code: DE
   output:
@@ -22,7 +22,7 @@
   period: 2022
   absolute_error_margin: 0.01
   input:
-    irs_employment_income: 5_000
+    adjusted_gross_income_person: 5_000
     filing_status: SURVIVING_SPOUSE
     state_code: DE
   output:

diff --git a/policyengine_us/tests/policy/baseline/gov/states/ga/tax/income/ga_withheld_income_tax.yaml b/policyengine_us/tests/policy/baseline/gov/states/ga/tax/income/ga_withheld_income_tax.yaml
@@ -2,7 +2,7 @@
   period: 2022
   absolute_error_margin: 0.01
   input:
-    irs_employment_income: 7_000
+    adjusted_gross_income_person: 7_000
     filing_status: JOINT
     state_code: GA
   output:
@@ -12,7 +12,7 @@
   period: 2022
   absolute_error_margin: 0.01
   input:
-    irs_employment_income: 7_000
+    adjusted_gross_income_person: 7_000
     filing_status: SURVIVING_SPOUSE
     state_code: GA
   output:
@@ -22,7 +22,7 @@
   period: 2022
   absolute_error_margin: 0.01
   input:
-    irs_employment_income: 5_000
+    adjusted_gross_income_person: 5_000
     filing_status: SURVIVING_SPOUSE
     state_code: GA
   output:

diff --git a/policyengine_us/tests/policy/baseline/gov/states/hi/tax/income/hi_withheld_income_tax.yaml b/policyengine_us/tests/policy/baseline/gov/states/hi/tax/income/hi_withheld_income_tax.yaml
@@ -2,7 +2,7 @@
   period: 2022
   absolute_error_margin: 0.01
   input:
-    irs_employment_income: 5_000
+    adjusted_gross_income_person: 5_000
     filing_status: JOINT
     state_code: HI
   output:
@@ -12,7 +12,7 @@
   period: 2022
   absolute_error_margin: 0.01
   input:
-    irs_employment_income: 5_000
+    adjusted_gross_income_person: 5_000
     filing_status: SURVIVING_SPOUSE
     state_code: HI
   output:
@@ -22,7 +22,7 @@
   period: 2022
   absolute_error_margin: 0.01
   input:
-    irs_employment_income: 2_000
+    adjusted_gross_income_person: 2_000
     filing_status: SURVIVING_SPOUSE
     state_code: HI
   output:

diff --git a/policyengine_us/tests/policy/baseline/gov/states/ia/tax/income/ia_withheld_income_tax.yaml b/policyengine_us/tests/policy/baseline/gov/states/ia/tax/income/ia_withheld_income_tax.yaml
@@ -2,7 +2,7 @@
   period: 2022
   absolute_error_margin: 0.01
   input:
-    irs_employment_income: 5_000
+    adjusted_gross_income_person: 5_000
     filing_status: JOINT
     state_code: IA
   output:
@@ -12,7 +12,7 @@
   period: 2022
   absolute_error_margin: 0.01
   input:
-    irs_employment_income: 5_000
+    adjusted_gross_income_person: 5_000
     filing_status: SURVIVING_SPOUSE
     state_code: IA
   output:
@@ -22,7 +22,7 @@
   period: 2022
   absolute_error_margin: 0.01
   input:
-    irs_employment_income: 2_000
+    adjusted_gross_income_person: 2_000
     filing_status: SURVIVING_SPOUSE
     state_code: IA
   output:
@@ -32,7 +32,7 @@
   period: 2023
   absolute_error_margin: 0.01
   input:
-    irs_employment_income: 10_000
+    adjusted_gross_income_person: 10_000
     filing_status: JOINT
     state_code: IA
   output:

diff --git a/policyengine_us/tests/policy/baseline/gov/states/id/tax/income/id_withheld_income_tax.yaml b/policyengine_us/tests/policy/baseline/gov/states/id/tax/income/id_withheld_income_tax.yaml
@@ -2,7 +2,7 @@
   period: 2022
   absolute_error_margin: 0.01
   input:
-    irs_employment_income: 20_000
+    adjusted_gross_income_person: 20_000
     filing_status: JOINT
     state_code: ID
   output:
@@ -12,7 +12,7 @@
   period: 2022
   absolute_error_margin: 0.01
   input:
-    irs_employment_income: 20_000
+    adjusted_gross_income_person: 20_000
     filing_status: SURVIVING_SPOUSE
     state_code: ID
   output:
@@ -22,7 +22,7 @@
   period: 2022
   absolute_error_margin: 0.01
   input:
-    irs_employment_income: 12_000
+    adjusted_gross_income_person: 12_000
     filing_status: SURVIVING_SPOUSE
     state_code: ID
   output:

diff --git a/policyengine_us/tests/policy/baseline/gov/states/il/tax/income/il_withheld_income_tax.yaml b/policyengine_us/tests/policy/baseline/gov/states/il/tax/income/il_withheld_income_tax.yaml
@@ -2,7 +2,7 @@
   period: 2022
   absolute_error_margin: 0.01
   input:
-    irs_employment_income: 15_000
+    adjusted_gross_income_person: 15_000
     filing_status: JOINT
     state_code: IL
   output:
@@ -12,7 +12,7 @@
   period: 2022
   absolute_error_margin: 0.01
   input:
-    irs_employment_income: 15_000
+    adjusted_gross_income_person: 15_000
     filing_status: SURVIVING_SPOUSE
     state_code: IL
   output:
@@ -22,7 +22,7 @@
   period: 2022
   absolute_error_margin: 0.01
   input:
-    irs_employment_income: 2_000
+    adjusted_gross_income_person: 2_000
     filing_status: SURVIVING_SPOUSE
     state_code: IL
   output: